Re: aped_bib broken?

On Sat, Mar 03, 2012 at 17:30 -0500, David P. Huenemoerder wrote:
> 
> I haven't used the aped_bib function before, but it doesn't seem to be
> working as advertised:
> 
> isis> l = where( trans(S,15,[2:7],1));
> isis> page_group(l);
> #  index        ion   lambda    F (ph/cm^2/s)  A(s^-1)  upper lower   label
>  195575 *      S XV    5.0387    2.534e-06   6.700e+13     7     1 1s1 - 1s2
>  201814 *      S XV    5.0631    4.142e-07   1.170e+08     6     1 1s1 - 1s2
>  204771        S XV    5.0645    0.000e+00   1.380e+08     3     1 1s1 - 1s2
>  195571 *      S XV    5.0665    8.222e-07   4.680e+11     5     1 1s1 - 1s2
>  204772 *      S XV    5.1015    8.666e-07   1.320e+06     2     1 1s1 - 1s2
> 
> isis> s = aped_bib(aped,l);
> 
> Reading database version 2.0.1 from /nfs/cxc/a1/share/atomdb
> unimplemented type: 1 file: /nfs/cxc/a1/share/atomdb/APED/s/s_15/s_15_IR_v2_0_1_a.fits
> Unable to typecast Undefined_Type to Struct_Type
> Traceback: get_struct_field_names

It's a bug in the error handling code.
I've appended a patch that fixes the problem (already
applied to our local isis installation).

Thanks,
John


diff --git a/share/fits_module_dep.sl b/share/fits_module_dep.sl
index aae8fd7..2321a97 100644
--- a/share/fits_module_dep.sl
+++ b/share/fits_module_dep.sl
_at_email.domain.hidden                {
                   % default:
                   vmessage ("unimplemented type: $type file: $file"$);
+                  continue;
                }

              refs = struct_append_strings (refs, r);




----
You received this message because you are
subscribed to the isis-users list.
To unsubscribe, send a message to
isis-users-request_at_email.domain.hiddenwith the first line of the message as:
unsubscribe